search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Pep8 cleanup #121

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

@ocefpaf I did some clean up for timeseries examples so that at least now timeseries for wofpy_config will have clean code. Hopefully I didn't miss or break anything (will test and confirm).

lsetiawan commented 7 years ago

Still works fine, though there's more to fix... gah.. https://travis-ci.org/ODM2/WOFpy/jobs/231666013#L8476 Don't merge. Will continue this work after I'm testing for postgresql.

emiliom commented 7 years ago

Don't merge. Will continue this work after I'm testing for postgresql.

Just so we're clear: @lsetiawan isn't waiting on me to merge this PR, right? After @ocefpaf's comments, I didn't know if it was ready to merge.

I leave it to the two of you to sort out when it's ready, and to merge it yourselves.

lsetiawan commented 7 years ago

Just so we're clear: @lsetiawan isn't waiting on me to merge this PR, right? After @ocefpaf's comments, I didn't know if it was ready to merge.

Nope, not waiting on you. Just trying to sort things out.

ocefpaf commented 7 years ago

After @ocefpaf's comments, I didn't know if it was ready to merge.

My comments are not a blocker to merge, that is why I gave the approval (GitHub's nice new feature BTW). I was mostly suggestions b/c we don't really need those docstrings just to make the linter happy: https://www.python.org/dev/peps/pep-0008/#a-foolish-consistency-is-the-hobgoblin-of-little-minds

lsetiawan commented 7 years ago

Merging this for now, since I'm going to update DAO, don't want to have conflicts.

emiliom commented 7 years ago

Sounds good