search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Add an option to connection_String of .cfg file #190

Closed JuliaBong closed 7 years ago

JuliaBong commented 7 years ago

I got some troubles about multi-thread of SQLite sometimes when I run the the example with the configuration file. Even WOFpy web service was not working well when I wanted to get values of specific time period. The error(e.g. Not Found error) was not occurred anymore after adding 'check_same_thread=False' part at the last line.

emiliom commented 7 years ago

@JuliaBong thanks for the contribution! Problems with SQLite multi-threading ring a bell. @lsetiawan, please follow up on the PR when you get a chance

emiliom commented 7 years ago

Thanks, @lsetiawan. Glad to hear the issue was in fact related to our earlier problem (#112). Were you able to run tests to confirm that this PR fixes that problem? (I'm guessing you're too busy this week to do that)

Thanks again, @JuliaBong!

lsetiawan commented 7 years ago

were you able to run tests to confirm that this PR fixes that problem? (I'm guessing you're too busy this week to do that)

Not quite sure what tests I can do because I've never seen this error in the scope of WOFpy dao using sqlalchemy queries rather than ODM2Python API. I will look into how I can make a test for this.

emiliom commented 7 years ago

were you able to run tests to confirm that this PR fixes that problem? (I'm guessing you're too busy this week to do that)

Not quite sure what tests I can do because I've never seen this error in the scope of WOFpy dao using sqlalchemy queries rather than ODM2Python API. I will look into how I can make a test for this.

I meant a test for the error reported in issue #112. My impression was that this PR also addressed that problem?

lsetiawan commented 7 years ago

@emiliom Ah. I see. I'll get to this next week. I'll starting testing wofpy with ODM2Python API for querying again, and see if this problem come up at all.