ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Hopefully last whack-a-unicode #197

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

Overview

This PR continues on #188 and hopefully address #148. Now the test and actual application uses the same way of encoding/decoding the content from the database.

lsetiawan commented 7 years ago

Sigh... tests are failing with decode error now... I thought that it worked a month ago.. darn.. let's see.. hmm..

ocefpaf commented 7 years ago

Sigh... tests are failing with decode error now... I thought that it worked a month ago.. darn.. let's see.. hmm..

The real issue here is that we did not find the "endpoints" of the data stream to do the conversion only at those points. (That happens b/c the code is quite convoluted and we are not the original authors. Although, at this point, not even the original authors could find the endpoints easily.)

We can only add more tests and try to remove as much of the "inner" conversions as we can.

PS: by conversion I mean the enconde/decode calls.

lsetiawan commented 7 years ago

I did it right, the test just didn't reflect a real life output. Ideally, we should use the database test that we now have, but for now, this is good. I need to focus on addressing the errors that @miguelcleon encounters. @ocefpaf please review this PR and merge when you think is good. Thanks 😄