search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Update production installation notes #78

Closed lsetiawan closed 7 years ago

emiliom commented 7 years ago

@lsetiawan, it looks like the document updates you've made assume WOFpy has been installed via a conda package that includes Filipe's new changes, including wofpy_config.py. Is that correct? If so, that's not what we have yet. My understanding is that, until a new conda package is created, the only thing that has changed from a user's point of view is the file path location of the example code that needs to be copied after git cloning (you also removed the git clone step).

Let me know if that's true. I won't merge the PR until I hear back.

lsetiawan commented 7 years ago

Hi Emilio,

Yea. That's correct. Darn. I will roll back and just change the file path. Thanks. Sorry.

Best, Don

On Apr 14, 2017 19:40, "Emilio Mayorga" notifications@github.com wrote:

@lsetiawan https://github.com/lsetiawan, it looks like the document updates you've made assume WOFpy has been installed via a conda package that includes Filipe's new changes, including wofpy_config.py. Is that correct? If so, that's not what we have yet. My understanding is that, until a new conda package is created, the only thing that has changed from a user's point of view is the file path location of the example code that needs to be copied after git cloning (you also removed the git clone step).

Let me know if that's true. I won't merge the PR until I hear back.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ODM2/WOFpy/pull/78#issuecomment-294267078, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ-jvJx6KVSmksd_u1iJfWb9JiKBeLA-ks5rwC3ygaJpZM4M-JXH .

emiliom commented 7 years ago

My suggestion is to keep those changes in a branch of yours (ie, don't get rid of them completely!). We'll want them eventually, once a new conda package is released. But yeah, at this time, we only want the changes that will allow someone following your instructions today to install and configure WOFpy. Thanks.

lsetiawan commented 7 years ago

Closing this for now.