search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Fixed core, waterml, and config imports #88

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

This will hopefully fix the import core failures during travis ci build.

ocefpaf commented 7 years ago

Thanks for addressing these imports @lsetiawan! There are probably more that needs to be made either absolute, like that, or relative inside the package. I prefer the former BTW.

lsetiawan commented 7 years ago

Darn it stopped at config still... looking for a fix.. don't merge yet

ocefpaf commented 7 years ago

Darn it stopped at config still... looking for a fix.. don't merge yet

Do you mean Travis-CI?

I was planning to review all the imports today but I don't want to duplicate the effort if you are tackling this. (I also want to avoid the need for rebasing for both of us :smile:)

lsetiawan commented 7 years ago

Do you mean Travis-CI?

Yea.

I was planning to review all the imports today but I don't want to duplicate the effort if you are tackling this.

Either way, just trying to help you out 😄 Let me know what I can get done.

ocefpaf commented 7 years ago

Either way, just trying to help you out 😄 Let me know what I can get done.

Please do :smile:

Let's just coordinate the effort. Ping me once you need a review/merge on this one, and let me know if you want to catch further absolute import failures.

I will work on something else and get back to the imports when I hear from you.

Thanks!

lsetiawan commented 7 years ago

Yea.. Looks like that would work. Thanks! Changing now.

lsetiawan commented 7 years ago

@ocefpaf What do you think? Should I merge this one?

ocefpaf commented 7 years ago

@ocefpaf What do you think? Should I merge this one?

Yep. LGTM.