Closed ocefpaf closed 7 years ago
It looks fine to me, just curious about a few things. Sorry for the massive amount of questions. Partly for my learning sake 😉
It looks fine to me, just curious about a few things. Sorry for the massive amount of questions. Partly for my learning sake 😉
No need to be sorry. That is healthy for both of us and the code base!
@ocefpaf Everything looks good to me, but I'll wait for @emiliom approval before merging. Thanks.
@lsetiawan can you review and merge this one? Unfortunately the changes are massive and I am not nearly done :weary:
But I don't want to do everything in one go to avoid disrupting other PRs with unnecessary rebases.
PS: I won't send another
flake8
PR today.