ODM2 / YODA-File

The YAML Observation Data Archive & exchange (YODA) File Format
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

duplicate data in timeseries yoda file #38

Open cdesyoun opened 8 years ago

cdesyoun commented 8 years ago

Jeff, I think there is duplicate data records below in your recent updated timeseries yoda file generated by ms excel.

Actions:
  - &ActionID0001 {ActionTypeCV:  "Observation", MethodObj: *MethodID0001, BeginDateTime:  "2010-06-03 11:15:00", BeginDateTimeUTCOffset:  -5, EndDateTime:  NULL, EndDateTimeUTCOffset:  NULL, ActionDescription:  "Generic observation action generated by Excel Template for TimeSeries v.0.3.0-alpha", ActionFileLink:  NULL}
  - &ActionID0002 {ActionTypeCV:  "Observation", MethodObj: *MethodID0001, BeginDateTime:  "2010-06-03 11:15:00", BeginDateTimeUTCOffset:  -5, EndDateTime:  NULL, EndDateTimeUTCOffset:  NULL, ActionDescription:  "Generic observation action generated by Excel Template for TimeSeries v.0.3.0-alpha", ActionFileLink:  NULL}
  - &ActionID0003 {ActionTypeCV:  "Observation", MethodObj: *MethodID0001, BeginDateTime:  "2010-06-03 11:15:00", BeginDateTimeUTCOffset:  -5, EndDateTime:  NULL, EndDateTimeUTCOffset:  NULL, ActionDescription:  "Generic observation action generated by Excel Template for TimeSeries v.0.3.0-alpha", ActionFileLink:  NULL}
FeatureActions:
  - &FeatureActionID0001 {SamplingFeatureObj:  *SamplingFeatureID0001, ActionObj:  *ActionID0001}
  - &FeatureActionID0002 {SamplingFeatureObj:  *SamplingFeatureID0001, ActionObj:  *ActionID0002}
  - &FeatureActionID0003 {SamplingFeatureObj:  *SamplingFeatureID0001, ActionObj:  *ActionID0003}
ActionBy:
  - {ActionObj:  *ActionID0001, AffiliationObj:  *AffiliationID0002, IsActionLead: TRUE, RoleDescription: NULL}
  - {ActionObj:  *ActionID0002, AffiliationObj:  *AffiliationID0002, IsActionLead: TRUE, RoleDescription: NULL}
  - {ActionObj:  *ActionID0003, AffiliationObj:  *AffiliationID0002, IsActionLead: TRUE, RoleDescription: NULL}

maybe the correction is as follows:

Actions:
  - &ActionID0001 {ActionTypeCV:  "Observation", MethodObj: *MethodID0001, BeginDateTime:  "2010-06-03 11:15:00", BeginDateTimeUTCOffset:  -5, EndDateTime:  NULL, EndDateTimeUTCOffset:  NULL, ActionDescription:  "Generic observation action generated by Excel Template for TimeSeries v.0.3.0-alpha", ActionFileLink:  NULL}
FeatureActions:
  - &FeatureActionID0001 {SamplingFeatureObj:  *SamplingFeatureID0001, ActionObj:  *ActionID0001}
ActionBy:
  - {ActionObj:  *ActionID0001, AffiliationObj:  *AffiliationID0002, IsActionLead: TRUE, RoleDescription: NULL}

Do I get misunderstood for this?

horsburgh commented 8 years ago

@cdesyoun - This is a known issue with the current Excel template. It is technically correct and not duplicate data. I can have three separate actions - one for each of the results in the file. But, it would be better to have only one action that generated all three (as you suggest). @sreeder was working on this issue right before she left on maternity leave. She may be able to give us an update on where she got to with that.

cdesyoun commented 8 years ago

In validation process, yoda tool does not check the duplicate records in yoda file. But, when loading yoda file into odm2 database, maybe these are in database if the duplication is not checked.