search

ODOT-PTS / TNExT

a web-based software tool developed for the visualization, analysis, and reporting of regional and statewide transit networks in the state of Oregon
15 stars 4 forks source link

Shapefile Export Results with day of week selected #110

Closed PPaulsonOregonDOT closed 6 years ago

PPaulsonOregonDOT commented 6 years ago

When exporting routes data from the shapefile export (See issue #65) using the day of the week selection function, for agencies whose GTFS data are bundled with another agency, the export only the provides .dbf file for that agency without any geometry data attached. I have attached the list of effected agencies, grouped by the bundled agency. It appears that the first agency listed in agency.txt in the GTFS file is exported, but the others are not.

irees commented 6 years ago

OK. It looks like trip agency id's are joined through gtfs_calendars. The serviceid_agencyid in gtfs_calendars is set to the first agency in the GTFS file, when in fact calendar.txt entries are not tied to any agency in particular, but are instead global service definitions for the feed. Creating either a better join or a work around.

Update: gtfs_trips has this value available in serviceid_agencyid; fix is to join svcids.serviceid_agencyid = gtfs_trips.serviceid_agencyid

irees commented 6 years ago

The above PR seemed to resolve the issue; will be on staging servers with the next update, probably today.

irees commented 6 years ago

On staging. You can test by selecting "May 2018", "Albany Transit System", and "Linn-Benton Loop" (these come from the same GTFS source file) and selecting Routes or Stops with today's date. Please re-open if there any further suggestions.

http://tna.trilliumtransit.com:8090/TNAtoolAPI-Webapp/ShapeFileExport.html

PPaulsonOregonDOT commented 6 years ago

In looking at the shapefile export that I just did for the full stops report (no date selected), out of the May 2018 DB, it appears that the effective end/start date and the arrival and departure have all been times concantenated into a single string and placed into the provider_nm field.

irees commented 6 years ago

Hi @PPaulsonOregonDOT -- I'm not able to reproduce the problem. Can you say which agencies you selected?

screenshot 2018-04-26 19 07 20

screenshot 2018-04-26 19 07 49

PPaulsonOregonDOT commented 6 years ago

@irees I have the same observation about the base data. I believe the error was a result of a post-export processing step I used to merge the full dataset together. I will continue to investigate, and re-open this thread if I think there is something about the data structure that is contributing to the issue.