search

OData / OData.Neo

111 stars 18 forks source link

CODE RUB: Fix File Name #34

Closed ahmedanwar100 closed 1 year ago

ahmedanwar100 commented 1 year ago

File renamed to ProjectionServiceTests.Exceptons.cs File To ProjectionServiceTests.Exceptions.cs

hassanhabib commented 1 year ago

@ahmedanwar100 rename the PR to CODE RUB: Fix File Name

ahmedanwar100 commented 1 year ago

@hassanhabib, can you please review it as I have renamed it.

Spectralgo commented 1 year ago

Hi @ahmedanwar100, you should name your branch like this: image

And your commits like that: image

If you take a look at the commit history or the other branches in this repo, you will see that every one of them are respecting some conventions.

If you want more info on this topic you can take a look at this: https://github.com/ElbekDeveloper/The-Standard-FAQ#branch-naming-convention

Hope it helps 😉

Spectralgo commented 1 year ago

@ahmedanwar100, I would recommend closing this PR and make a whole new branch.

ahmedanwar100 commented 1 year ago

Ok great

On Tue, 1 Nov 2022, 5:42 am Florian Renard, @.***> wrote:

@ahmedanwar100 https://github.com/ahmedanwar100, I would recommend closing this PR and make a whole new branch.

— Reply to this email directly, view it on GitHub https://github.com/OData/OData.Neo/pull/34#issuecomment-1297860782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILYWTVWFKVKOPZQSY77IZDWGBRQDANCNFSM6AAAAAARLODFQ4 . You are receiving this because you were mentioned.Message ID: <OData/OData .@.***>