search

OData / ODataConnectedService

A Visual Studio extension for generating client code for OData Services
Other
79 stars 41 forks source link

Fix odata-cli exclusions #364

Closed gregwinterstein closed 1 year ago

gregwinterstein commented 1 year ago

As noted in #341 the exclude-schema-types option (and other exclusion options) are ignored by the odata-cli. This is because the option is described as a comma-separated list but implemented as a list.

This change converts the exclusion options into strings and splits the strings on commas when passing the exclusions into the generators.

This fixes issue #341

gregwinterstein commented 1 year ago

Any tests?

@habbes The current tests for the command-line are marked as [Ignore("to be removed")] and use the CodeGenWithT4TemplateFromCommandline method. If CodeGenWithT4TemplateFromCommandline is still available and is not deprecated, tests could be created to pass command-line parameters and validate the resulting code.

KenitoInc commented 1 year ago

@gregwinterstein Can you rebase the PR?

gregwinterstein commented 1 year ago

@gregwinterstein Can you rebase the PR?

@KenitoInc I have rebased the pull request as requested.