OData / odata.net

ODataLib: Open Data Protocol - .NET Libraries and Frameworks
https://docs.microsoft.com/odata
Other
688 stars 349 forks source link

Metadata document is not in camel Case #1787

Open agrabhi opened 4 years ago

agrabhi commented 4 years ago

Even when we use EnableLowerCamelCase, metdata document is not in proper camelCase

Assemblies affected

All

Reproduce steps

Call metadata endpoint of any service

Expected result

 <Property Name="userFlowType" Type="microsoft.cpim.api.dataModels.userFlowType" Nullable="false" />

Actual result

 <Property Name="userFlowType" Type="Microsoft.Cpim.Api.DataModels.UserFlowType" Nullable="false" />

Additional detail

Optional, details of the root cause if known. Delete this section if you have no additional details to add.

gathogojr commented 4 years ago

@agrabhi Please note EnableLowerCamelCase only applies to property names not to types. A type like Edm.String will still appear the same and so will a type like Microsoft.Cpim.Api.DataModels.UserFlowType

agrabhi commented 4 years ago

but type should also be camelCased. For example Microsoft Graph metadata document is all in camelCase

gathogojr commented 4 years ago

@agrabhi Do you have the option of naming the namespace and type using the desired casing?

agrabhi commented 4 years ago

Nope. C# coding guideline wise, camel Case is discouraged.

gathogojr commented 4 years ago

This could be implemented as an opt-in feature