search

OData / odata.net

ODataLib: Open Data Protocol - .NET Libraries and Frameworks
https://docs.microsoft.com/odata
Other
686 stars 349 forks source link

Metadata diff moving from 7.9.4 to 7.12.0 #2507

Open aloknigam247 opened 2 years ago

aloknigam247 commented 2 years ago

We are upgrading OData lib version from 7.9.4 to 7.12.0. And when we did diff of metadata generated from 7.9.4 vs 7.12.0 We observed metadata has a small diff as shown below. Seems like a new attribute Scale="Variable" is added to type Edm.Decimal

image

Assemblies affected

We are seeing the diff when upgrading from 7.9.4 to 7.12.0

Additional detail

This is a single occurance of Scale attribute in metadata. This creates some doubts too, does only Edm.Decimal attributed with "Variable".

Creating an issue to check if this difference creates compatibility issues in client side.

xuzhg commented 2 years ago

@aloknigam247 see the PR at: https://github.com/OData/odata.net/pull/2346

Here's the comment:

https://github.com/OData/odata.net/blob/master/src/Microsoft.OData.Edm/Csdl/Serialization/EdmModelCsdlSchemaXmlWriter.cs#L282-L285

aloknigam247 commented 2 years ago

@xuzhg though comment says it the change is done to preserver backward compatibity. We just want to confirm for our case once again we were using 7.9.4 earlier and now moving to 7.12.0 will the client see any behaviour changes at their end. Our client may be using any version of odata in this case. We don't have control over it, but we can assume that they are using the same version before 7.12.0 upgrade and after upgrade.