OData / odata.net

ODataLib: Open Data Protocol - .NET Libraries and Frameworks
https://docs.microsoft.com/odata
Other
686 stars 349 forks source link

Port E2E tests to .NET 8 in ODL 8 #2878

Open habbes opened 7 months ago

habbes commented 7 months ago

Our E2E tests were written for .NET Framework. Let's port them to .NET 8 in ODL 8.

The PR: https://github.com/OData/odata.net/pull/2851 removed e2e tests from the build pipeline when updating ODL 8 target frameworks to .net8.0 and .net48.

We should fix the e2e tests and add them back to the pipeline.

habbes commented 7 months ago

We should take the opportunity to also rename the ODataSimplifiedService now that we have removed the ODataSimplifiedOptions. See: https://github.com/OData/odata.net/pull/2872/files#r1500357347

robertmclaws commented 6 months ago

When you do this, please consider looking at the Restier end-to-end tests and using that approach. We've been able to guarantee consistent releases because we built a clean and simple unit test structure, and then leveraged Breakdance to set of the tests consistently and minimize boilerplate code in the tests.

The structure has allowed Restier to catch several issues between releases that the OData core tests did not catch. I know it's different from what you are used to, but it's worth a look.

Also, when you do this, please remove custom commands from the unit test projects, like the post-build call to SN.exe. Stuff like that means you can't run the tests in a Codespaces workspace, for example.