917860: Accessibility fix for tab items narrations

OData / odataorg.github.io

Staging site and collaboration repository for http://www.odata.org

MIT License

63 stars 101 forks source link

917860: Accessibility fix for tab items narrations #210

Closed gathogojr closed 4 years ago

gathogojr commented 4 years ago

Description

This PR fixes this issue where the screen reader narration for tab items is misleading. The three tabs OData v4, OData v3 and OData v2 are incorrectly narrated as

OData v4 tab item 1 of 1, OData v3 tab item 1 of 1 and OData v2 tab item 1 of 1

respectively, instead of

OData v4 tab item 1 of 3, OData v3 tab item 2 of 3 and OData v2 tab item 3 of 3

Link to page: https://www.odata.org/odata-services/

gathogojr commented 4 years ago

Would be nice to create an issue on github and link it to the PR :-)

Is that really necessary and what value does it add considering a work item exists in ADO and the ID forms part of the PR title. Tracking and reporting is done from ADO so I can understand the requirement to replicate an issue reported on GitHub on ADO but not vice versa

gathogojr commented 4 years ago

@g2mula Added and linked GitHub issue