OData / odataorg.github.io

Staging site and collaboration repository for http://www.odata.org
MIT License
63 stars 101 forks source link

Corrected aria headers #231

Closed wachugamaina closed 4 years ago

wachugamaina commented 4 years ago

Description: Basically Im removing the role="heading" tag from the below pages so that the narrator can use the preferred tag. With the role="heading" tag, the reader reads all heading levels as heading, when removed, it reads them appropriately as H1, H2 etc.

see work item https://dev.azure.com/IdentityDivision/Engineering/_queries/query/63f49107-d74b-44c1-a570-c3fdaa2758f0/ Environment Details:

URL:https://www.odata.org/

Browser Details: Microsoft Edge 44.18362.449.0​

​OS Details:​ Microsoft windows 10 enterprise ​ Version: 1909 Build 18363.592​ ​ Note:​ The same issue is present in the below pages​ 1.URI Conventions(OData Version 2.0) ​ 2.Operations(OData Version 2.0 )​ 3.Batch Processing (OData Version 2.0)​ 4.Atom Format(OData Version 2.0)​ 5.JSON Format(OData Version 2.0)​ ​ NVDA behaviour:​ NVDA is reading properly, it is not announcing all headings as heading level 1.​ ​ Repro Steps: ​​​ 1)Start Narrator​ 2)Hit the URL "https://www.odata.org/" and login with appropriate credentials to open Odata website​ 3)Tab till 'Developers' link and press enter​ 4)Tab till 'Documentation' option and press enter​ 5)Tab till "OData version 3.0" link and press enter​ 6)Tab till "OData Version 3.0 JSON Verbose Format" link and press enter​ 7)Verify All headings present in the page narrator is announcing as heading level 1 or not​ ​ Actual Result: ​​​ All headings present in the page Narrator is announcing incorrectly as heading level 1​ ​ Expected Result:​ All headings present in the page Narrator shouldn't announce as heading level 1​ ​ User Impact: ​​ Screen reader users will get confused if Narrator is announcing all headings as heading level 1 ​ ​ MAS Reference: ​​​ https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}