OData / odataorg.github.io

Staging site and collaboration repository for http://www.odata.org
MIT License
63 stars 101 forks source link

Fix/tabs accessibility #360

Closed odero closed 1 year ago

odero commented 1 year ago

For reviewers: click the individual commits for review. You can skip the "Fix spacing and indentation commit" - it's why I had it as a separate commit

Fixes

gathogojr commented 1 year ago

@odero This pull request is extremely hard to review. It's hard to pick out the material changes in the diff. I think the html formatting changes should have been made in a different pull request.

wandeg commented 1 year ago

Do you have before and after screenshots?

habbes commented 1 year ago

Could you update the description with a summary of the issue, the changes made and how they fix the issue?

odero commented 1 year ago

@gathogojr, @habbes - see the PR description - @wandeg - it's a screen-reader fix, can't capture a screenshot for that

odero commented 1 year ago

Deleted the spacing and indentation commit. Only showing actual changes now

marabooy commented 1 year ago

Could you confirm if the js code in line 1366 needs to be updated to not trap user focus using tab index or probably works great now