Closed odero closed 1 year ago
@odero This pull request is extremely hard to review. It's hard to pick out the material changes in the diff. I think the html formatting changes should have been made in a different pull request.
Do you have before and after screenshots?
Could you update the description with a summary of the issue, the changes made and how they fix the issue?
@gathogojr, @habbes - see the PR description - @wandeg - it's a screen-reader fix, can't capture a screenshot for that
Deleted the spacing and indentation commit. Only showing actual changes now
Could you confirm if the js code in line 1366 needs to be updated to not trap user focus using tab index or probably works great now
For reviewers: click the individual commits for review. You can skip the "Fix spacing and indentation commit" - it's why I had it as a separate commit
Fixes
aria-haspopup="true" aria-expanded="false"
for the readertabindex=-1
since it was resulting in incorrect navigation when hitting tab to move across elements