search

OE-FET / keithley2600

Python driver for Keithley 2600 series instruments.
https://keithley2600.readthedocs.io
MIT License
41 stars 17 forks source link

small fix #2

Closed quaeritis closed 5 years ago

quaeritis commented 6 years ago

hi small fixes for the setup.py

I also think it would be good to remove the dependencies to 'QtPy' and 'matplotlib'.

In addition, the Keithley2600reference.pdf should be removed from the repo. Instead, a link to PDF in the README.

What is your opinion on this subject?

Sorry for my bad english.

quaeritis commented 6 years ago

I also think that the repo / project name and the import name should be identical so Keithley2600-driver or Keithley2600.

samschott commented 5 years ago

Thanks again. Agreed on removing the Keithley2600reference.pdf, it only takes up space and is easily accessible online.

On removing the QtPy and matplotlib dependencies: Both are possible but will need some adjustments to CustomXepr first. The driver was initially part of a larger project, CustomXepr, and I only split it off recently since it is of general use. Parts of CustomXepr still expect plot() and save() methods, and rely on save() opening a GUI prompt. I will need to make the appropriate changes first.

samschott commented 5 years ago

Right. I removed the QtPy dependency but am keeping Matplotlib for now. Even through this goes beyond what a "driver" should do, I quite like the plotting functionality.

Also, the real driver is Keithley2600Base; Keithley2600 already incorporates many higher level functions which CustomXepr depends on.