search

OE4T / meta-tegra

BSP layer for NVIDIA Jetson platforms, based on L4T
MIT License
384 stars 215 forks source link

Refactor UEFI capsule generation #1527

Closed igoropaniuk closed 1 month ago

igoropaniuk commented 2 months ago

Refactor UEFI capsule generation. Drop BUP-specific recipes and move all logic to UEFI capsule generation recipe, as suggested in [1]

[1] https://github.com/OE4T/meta-tegra/discussions/1492

ichergui commented 2 months ago

Thanks @igoropaniuk for the PR. I will check the changes and get back to you.

igoropaniuk commented 2 months ago

@ichergui not really, I've verified only that cap files (with the same size as without these changes) are generated and deployed. I can test update mechanism if needed, but I haven't touched anything in the way how that capsule updates are processed in runtime

ichergui commented 2 months ago

@igoropaniuk Please do

madisongh commented 2 months ago

@Lexmark-chad It would be good for you to review this as well, if you can

ichergui commented 2 months ago

@igoropaniuk Any update about this PR ?

igoropaniuk commented 2 months ago

@ichergui I'm currently traveling, will get back to it when I'm back (in a week)

ichergui commented 1 month ago

Hi @igoropaniuk Please update this PR when you have chance. Let us know if you need help.

ichergui commented 1 month ago

Hi @igoropaniuk Thanks for the updates. Could you please rebase your banch on top of master then push again ?

igoropaniuk commented 1 month ago

@ichergui I've pushed rebased version, but looks like sanity checks are still failing (and issues reported are not related to my changes):

ERROR: /scratch/buildworker/meta-tegra-master-checklayer/build/poky/meta-tegra/recipes-devtools/cuda/nativesdk-cuda-environment_1.0.bb: Using S = ${WORKDIR} is no longer supported
ERROR: /scratch/buildworker/meta-tegra-master-checklayer/build/poky/meta-tegra/recipes-bsp/tegra-binaries/tegra-helper-scripts-native_35.5.0.bb: Using S = ${WORKDIR} is no longer supported
ERROR: Parsing halted due to errors, see error messages above
madisongh commented 1 month ago

Yeah, the changes for disallowing `S = "${WORKDIR}" have gone into OE-Core master... I'll try and make some time to work on that today.

madisongh commented 1 month ago

@igoropaniuk Try rebasing on master latest, should work better now.

igoropaniuk commented 1 month ago

@ichergui @madisongh @Lexmark-chad @kekiefer do you have any additional comments/objections/suggestions? thanks

madisongh commented 1 month ago

I think we're good. I'm running a couple of build tests in preparation for merging. Thanks!