search

OE4T / meta-tegra

BSP layer for NVIDIA Jetson platforms, based on L4T
MIT License
420 stars 230 forks source link

at least typo in tegra-storage-layout-base_35.5.0.bb #1684

Closed tjhgit closed 3 months ago

tjhgit commented 3 months ago

bug report here

dwalkes commented 3 months ago

Thanks @tjhgit however I think rather than changing the BSP layer for this mender specific issue it would probably be better to either: 1) Modify the mender layer to use the updated location in scarthgap (preferred) or 2) Put this change in a bbappend within the mender layer.

Note that I think scarthgap support for mender is still a work in progress, you may want to sync up with the PR at https://github.com/mendersoftware/meta-mender-community/pull/402

tjhgit commented 3 months ago

ok @dwalkes . But there is still the typo in the meta-tegra code: PARTITION_LAYOUT_EXERNAL . It is missing a T.

dwalkes commented 3 months ago

@tjhgit thank you I see that now. Can you modify the commit to change only this single line?

dwalkes commented 3 months ago

You also need to sign off your commit per our contributor guidelines.

tjhgit commented 3 months ago

@dwalkes . Regarding changing the rest, I assume this would be here, right: ./meta-mender-tegra/recipes-bsp/tegra-binaries/tegra-storage-layout-base_%.bbappend ?

Sure will modify the commit to only the single line.

dwalkes commented 3 months ago

@tjhgit correct, although it looks like there should be handling for this already at https://github.com/mendersoftware/meta-mender-community/blob/scarthgap/meta-mender-tegra/recipes-bsp/tegra-binaries/tegra-storage-layout-base_%25.bbappend#L4

dwalkes commented 3 months ago

@tjhgit still missing signoff and you should squash your commits. I can just propose a PR myself now that I understand the issue if you prefer.

tjhgit commented 3 months ago

@dwalkes . Sorry I am not so good at this ... I issued a git commit -s ... So kind that you offer to take over. Regarding: https://github.com/mendersoftware/meta-mender-community/blob/scarthgap/meta-mender-tegra/recipes-bsp/tegra-binaries/tegra-storage-layout-base_%25.bbappend#L4 , I think this function is using the wrong location: do_install:append:tegra194()

dwalkes commented 3 months ago

So kind that you offer to take over

No problem, thanks for reporting. I've opened https://github.com/OE4T/meta-tegra/pull/1685

I think this function is using the wrong location: do_install:append:tegra194()

Makes sense, so yes this is the change you could propose in that layer in a new PR.