OE4T / tegra-demo-distro

Reference/demonstration distro for meta-tegra
MIT License
73 stars 74 forks source link

docker broken on latest dunfell branch commit "http: invalid Host header" #277

Open dwalkes opened 10 months ago

dwalkes commented 10 months ago

I just realized docker is completely broken on the latest dunfell branch of tegra-demo-distro with demo-image-full, I believe due to this issue. Any attempts to start a container fail with

root@jetson-nano-2gb-devkit:~# docker run hello-world
Unable to find image 'hello-world:latest' locally
latest: Pulling from library/hello-world
70f5ac315c5a: Pull complete
Digest: sha256:88ec0acaa3ec199d3b7eaf73588f4518c25f9d34f58ce9a0df68429c5af48e8d
Status: Downloaded newer image for hello-world:latest
http: invalid Host header

I don't see any fixes for this in meta-virtualization dunfell branch, nor do I see any in the corresponding docker-ce 19.03 or moby 19.03 branches.

I have verified this was introduced with this poky patch and have verified that reverting this commit resolves the issue.

I would rather just switch to kirkstone-l4t-r32.7.x, however I think there's a blocking issue there at https://github.com/OE4T/meta-tegra/pull/1194 which would need to be backported before my deepstream docker example will work on kirkstone, and it looks like it won't be trivial to backport that one (although I haven't fully wrapped my head around it yet).

I’m curious if anyone has suggestions about how to resolve and/or if anyone else cares about docker support on dunfell.

moto-timo commented 10 months ago

CVE patches can be imperfect. So it is possible something specific about that poky commit is at issue. If you can figure out some hints as to how it broke things, you can either file a bug or send email to the mailing lists.

dwalkes commented 10 months ago

Thanks @moto-timo

If you can figure out some hints as to how it broke things, you can either file a bug or send email to the mailing lists.

I think it's spelled out here ... as I understand it a breaking change in a CVE for go which required a change on docker to accomodate. The problem is that docker 19.03 from dunfell isn't maintained upstream based on discussion here in the meta-virtualization mailing list.

I've posted a message to meta-virtualization asking for suggestions.