search

OER-WEB-TEAM / design-system--drupal-theme

1 stars 0 forks source link

Video (Card) - Create new component #18

Closed AlexVanK closed 5 months ago

AlexVanK commented 6 months ago

@emsaiz Currently we have video component as a variation of a card...

image

We need to have it as dedicated component itself. Did we talk about this in the beginning? I thought so... but then we discarded the idea. However at the moment, I'm restructuring the flow of the documentation part of the components, and I need the video component to be separate!

Could you mock me up something with a default and variation views?

emsaiz commented 6 months ago

Done! I can put in the text. Let me know if you think I missed something! https://xd.adobe.com/view/124158b0-1037-4ee2-b081-aef1353d537a-4712/ image

emsaiz commented 6 months ago

These are only for YouTube videos right? Do we need to offer guidance for what people should do with non-YT video content like modules?

AlexVanK commented 5 months ago

Ems, I'm going to update the video layout a bit: you cannot coerce a video to fix exactly a certain area (the blue in your mockup), because that would have to coerce also the other side of the card.

But the height of the other part of the card is defined by the amount of copy, and if there's too much copy the card just gets taller:

Image

If you reduce the copy, then the height of the card is defined by the amount of copy and width of the card itself. Eventually it all comes down to how much text there is:

Image

Forcing the users to insert a maximum amount of words is a restriction that is next to impossible to enforce. Especially in a .gov environment, where they are very sensitive about their content, the descriptions are going to be different.

So I'll make the video be on the side, without the border so that the layout doesn't seem be so restricted by the content...

emsaiz commented 5 months ago

Ok thanks for letting me know! Sounds good 👍

AlexVanK commented 5 months ago

I also introduced a new variation -- let me know what you think https://styleguide.od.nih.gov/components/video#collapsible-info