search

OER-WEB-TEAM / design-system--drupal-theme

1 stars 0 forks source link

Documentation of Utility Nav is wrong #43

Closed AlexVanK closed 5 months ago

AlexVanK commented 5 months ago

Currently the utility nav documentation assumes a new website to setup search with default search module -- in which case a template is provided and we're all good.

But in the case of custom search (e.g.: elastic search) a custom search bar needs to be created as a block and placed in the proper region.

Documentation needs to cover both scenarios.

Also the template name for the utility nav is wrong. There is no such thing as "Utiliy Nav" on Drupal, it's called Tools nav. Rename template accordingly and describe setup in documentation

AlexVanK commented 5 months ago

Also consider moving utility nav into right place when installing theme. These should be possible with Drupal setup config system (yml)

emsaiz commented 5 months ago

Ok I have some slight iterations to the current utility nav. We might need more if we still don't like these but I didn't want to do anything too extra if we don't need it.

Adobe XD Link: https://xd.adobe.com/view/124158b0-1037-4ee2-b081-aef1353d537a-4712/

NOTE: I tried restructuring the page info hierarchy to account for the two different types of set ups. I made the "Responsive" and "Customization" sections their own H2s but maybe those instructions just pertained to the default search module? Anyways, feel free to disregard!

NOTE 2: "Customization" section is repeated from "Paginator" component.

image

AlexVanK commented 5 months ago

Taken care of!