search

OER-WEB-TEAM / design-system--drupal-theme

1 stars 0 forks source link

Theme header section should not load logo from local file system #55

Closed AlexVanK closed 4 months ago

AlexVanK commented 4 months ago

Since the theme is meant to be a parent theme, and subtheme usually load a custom logo depending on the site, we should not store a default logo on the file-system like this: image

That would be just a waste of space since it's going to get replaced anyway. Instead we're going to load it from the logo repository (this is what the final user should do also, but we cannot enforce that)

AlexVanK commented 4 months ago

The block--system-branding-block.html.twig has been patched to the following: image

Note that the first image loads the logo supplied in to the site from the /admin/appearance/settings/ interface of the current active theme. The second image provides a fallback logo for mobile view. In most cases, the logo can fallback to the NIH-badge-no-tagline, the user can always override this while templating on the subtheme.