search

OER-WEB-TEAM / design-system--drupal-theme

1 stars 0 forks source link

Spinner Component - remove extra spinner colors #8

Closed emsaiz closed 6 months ago

emsaiz commented 6 months ago

Feel free to disagree...

I think we should show only primary/secondary color spinners and growing loading indicators. I think having all colors gives the impression that they can be any color the customer wants or that there are use cases for using different ones.

I know you are very intentional with what you've done on each page and I don't want to disregard that so let me know what you think!

AlexVanK commented 6 months ago

I remember there have been talks about removing the extra colors. Since the component is so barebone I won't do that for now otherwise we will be left with almost an empty page.

Marking this issue as https://github.com/OER-WEB-TEAM/design-system--drupal-theme/labels/wontfix for now. Feel free to re-open the issue if other things come up about it. I don't remember the full convo tbh.