search

OFFIS-DAI / mango

Modular Python-based agent framework to implement multi-agent systems
https://mango-agents.readthedocs.io/
MIT License
12 stars 2 forks source link

add delayed container start #131

Closed maurerle closed 1 day ago

maurerle commented 6 days ago

This solves having sync creation of as_agent_process.

fixes #129

This is based on top of the described wanted behavior in: https://github.com/maurerle/mango/commit/eaccadec28fcde55236d9202637a8929feb8ce7a

Dill has to be dumped on the creation of the mirror agent function and not later. Otherwise this leads to very unexpected behavior (storing the state of the variables at the time of dumping, which is then the same for all delayed agent_creators, leading to duplicate agent ids)

Furthermore, it was missing to call on_ready in mirror containers, which is fixed as well through this PR

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (b0c1850) to head (a080e76). Report is 13 commits behind head on development.

Files with missing lines Patch % Lines
mango/container/mp.py 95.65% 1 Missing :warning:
mango/container/mqtt.py 50.00% 1 Missing :warning:
mango/container/tcp.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #131 +/- ## =============================================== + Coverage 88.65% 88.92% +0.27% =============================================== Files 22 22 Lines 2407 2448 +41 =============================================== + Hits 2134 2177 +43 + Misses 273 271 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maurerle commented 4 days ago

It probably helps to only review the changes since yesterday's review:

https://github.com/OFFIS-DAI/mango/compare/9cf064adf17468d06f4f3597d193c2d65264f170...add_mp_tests