search

OFFLINE-GmbH / oc-gdpr-plugin

October CMS plugin to make websites GDPR and ePrivacy compliant
https://octobercms.com/plugin/offline-gdpr
MIT License
36 stars 20 forks source link

Optimize cookieBanner component #11

Closed tobias-kuendig closed 6 years ago

tobias-kuendig commented 6 years ago

via via https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/issues/8

ghost commented 6 years ago

Add example banner messages for different EU countries

~Have read up and it seems the message doesn't matter, depending on each country although there are different laws within each country with regards to the Banner and I will add the list below. Maybe this can be added to the notes section to help users.

damsfx commented 6 years ago

@ayumihamsaki ... awesome work !

ghost commented 6 years ago

Also could create a list for the "Contact Links of Data Controller" and place the list of links in the Info and Help Section.

For example GA has a special Opt-Out webpage that should be linked and most people would not know about it. So making a list of the most common ones and placing it in the new Info and Help Section should also make things easier to fill out the form.

e.g.

aaa

damsfx commented 8 months ago
  • [x] Add an option to hide cookie group checkboxes (c519c8d)

This commit don't add an option to show/hide cookie group checkboxes, but removed them completely.

@tobias-kuendig Are you open to a PR that re-introduced then in a dedicated component (maybe banner plus) ?

tobias-kuendig commented 7 months ago

@damsfx that was a long time ago, so I have no idea what the reasoning was.

What would you think about a PR that adds the properties back on the component so you can utilize them in your partials? I'd rather not have an additional component to maintain.

damsfx commented 7 months ago

@damsfx that was a long time ago, so I have no idea what the reasoning was.

🤣

What would you think about a PR that adds the properties back on the component so you can utilize them in your partials? I'd rather not have an additional component to maintain.

As I didn't get an answer from you and needed one quickly, I created my own plugin to add this new component: https://github.com/Hounddd/wn-gdprplus-plugin

I really needed a component that would simplify my work with Google Consent Mode v2. By the way, I used CSS variables to quickly "theme" the component.

Of course, I prefer the idea of a more universal component that would allow the display of a simple or more complex banner. On the other hand, I think that the way the user's response is handled differs completely from one display to another.
That's why I opted for a component that extends the basic component, thus avoiding too much maintenance.

It's up to us to find the best options to offer the best of both worlds.