OFFLINE-GmbH / oc-gdpr-plugin

October CMS plugin to make websites GDPR and ePrivacy compliant
https://octobercms.com/plugin/offline-gdpr
MIT License
36 stars 20 forks source link

Initial Status field still present in fieldlist #22

Closed CptMeatball closed 6 years ago

CptMeatball commented 6 years ago

Since 1.1, the initial status of a cookie is removed. However, the field is still present in the fields.yaml (https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/blob/develop/models/cookie/fields.yaml#L15).

tobias-kuendig commented 6 years ago

The field is okay but there's a bug in the migration file. It should remove the column from the cookie_groups table, not the cookies table.

The initial_status was only removed from the groups.

tobias-kuendig commented 6 years ago

This has been corrected in ded31ef. Thanks for bringing this to our attention!

dathwa commented 2 years ago

Bit confused about this. It's my understanding that if the initial_status for the cookie/module is set to 1 (Have turned on at Start-up), then the cookie/module should be printed; google-analytics GO. But this is not the case. I'm on OCMS2 build 2.1.16. Can someonr please confirm? Thank-you. E.g. ` {% if gdprCookieAllowed('google-analytics') %}

-- google-analytics GO --

{% else %}
    <h1>-- google analytics denied --</h1>
{% endif %}` 
tobias-kuendig commented 2 years ago

initial_status = true means, that the cookie is enabled by default, once the end user accepts cookies.

If you want a cookie to be always set, wheter or not the user accepts it, put it in a group of required cookies. Please note that enabling cookies like Google Analytics by default is not GDPR compliant. You can only mark absolutely required cookies (like a session cookie) to be set without consent.