search

OFFLINE-GmbH / oc-gdpr-plugin

October CMS plugin to make websites GDPR and ePrivacy compliant
https://octobercms.com/plugin/offline-gdpr
MIT License
36 stars 20 forks source link

Updated Banner CSS and Added Dismiss Button #37

Closed ghost closed 6 years ago

ghost commented 6 years ago

Updated the Banner CSS as didn't work right on Mobile devices, font-size way too small for mobile devices (Web Standards says 16px or larger), Banner way too large and hit the 30% Google Penalty Limit (under bad ads), bad touch-points, added Accessibility, WAI-ARIA, missing rel-tag, hover effects, responsive banner correction, etc., see issue:

https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/issues/26

Needs the PHP Code for: "onDismiss" to be coded. Also could you create a "onShow" for users to add a button for re-showing the banner see issues:

https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/issues/32 https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/issues/23

ghost commented 6 years ago

Ok that is ready for processing now,... (Sorry added 5 commits - I decided to throw it through a WCAG 2 AA Spec testing tool as well).

ghost commented 6 years ago

(When I said "Throw it in the bin" I mean when you do this update, you should tell users to upgrade their CSS to this new one - otheriwse new features won't work. So they need to throw the old CSS away). Sorry for any misunderstanding!

ghost commented 6 years ago

Added another 2 commits: