search

OFFLINE-GmbH / oc-gdpr-plugin

October CMS plugin to make websites GDPR and ePrivacy compliant
https://octobercms.com/plugin/offline-gdpr
MIT License
36 stars 20 forks source link

Why the "hard_reload" is no longer available? #54

Closed iboved closed 5 years ago

iboved commented 5 years ago

Why the "hard_reload" is no longer available? Why did you remove this option? This is a useful option. Here you didn't remove this propery. And here we have this option. But why did you delete the property declaration - public $hardReload = false; at the top of the CookieBanner class? Thanks for the answer.

tobias-kuendig commented 5 years ago

Thanks for pointing out the dead code. The property simply wasn't removed completely by accident.

What's your use-case for the hard reload option? This offers nothing you cannot do with the soft reload option we currently provide. Also, the user experience suffers a lot when a hard reload is triggered.

iboved commented 5 years ago

@tobias-kuendig I have to move all my analytic codes in one partial if I use soft reload. P.S. Here and here we also have mentions of the "hard_reload" property.

tobias-kuendig commented 5 years ago

Thanks, the code has been removed too.

You can always overwrite the cookieBanner/optin.htm partial and decide for yourself what to do in the data-request-success attribute. You could even send the data-request to an other component that you control yourself. Just make sure to register the user's decision in the consent cookie.