Open SamBrishes opened 4 months ago
Thank you for your suggestion. I understand the advantages you're highlighting.
Currently, I prefer the integration with the Rainlab User plugin, as I've developed extensive functionality around it in conjunction with the Mall plugin. For instance, in several paid membership sites I manage, the OFFLINE Mall plugin facilitates the initial membership sale and sets expiry dates in an extended column of the User model. Annually, a scheduled task prompts users to renew their membership.
Additionally, the ability to impersonate user accounts is beneficial. Furthermore, other Rainlab plugins like the Campaign Manager, which I use to send emails, also require the User plugin and only target users with valid memberships.
If the User plugin were to become incompatible, it would significantly impact my projects. Could you confirm whether your updates will maintain optional compatibility with the User plugin? I'd appreciate hearing more about your plans.
Hello,
thanks for sharing your use-cases.
Of course, RainLab\User will stay compatible with Mall and will also stay as dependency and be required for using the web-store (or additional features). Just the requirement of the Mall\Customer model relating to a RainLab\User model would be made optional and thus preventing unnecessary RainLab\User accounts, such as those created for guest orders.
Seems like you aren't relying on guest orders anyway, and require a valid and working RainLab\User model for your (customer) projects.
However, considering your use cases, I guess the best way to handle this is to make the whole requirement-stuff configurable. This would make it even easier to prevent existing set-ups from causing any problems.
Sam.
Hi @SamBrishes,
If backward compatibility with the Rainlab User plugin is ensured, I see no reason not to consider your proposal.
Hello,
In my opinion, the required relationship between Mall\Customer and RainLab\User model prevents a few additional use cases, above all, but not exclusively, when combining Mall with existing ERP or CRM solutions (such as eBay or Odoo).
Using an optional relationship would allow managing customers and users separately and connect them when the customer needs a login for the web-store or website.
Advantages
Breaking-Changes
As far as I can see, there are no major breaking changes.
Is there anything against it?
What do you think @tobias-kuendig , @chocolata , @xyz1123581321?
Sincerely,\ Sam.