search

OFFLINE-GmbH / oc-mall-plugin

:convenience_store: E-commerce solution for October CMS
https://offline-gmbh.github.io/oc-mall-plugin
MIT License
169 stars 114 forks source link

Omnipay installs a lot of dependencies / Upgrade to Omnipay 3.0 #124

Closed alxy closed 5 years ago

alxy commented 5 years ago

Currently, the composer process requires the main omnipay package: https://github.com/OFFLINE-GmbH/oc-mall-plugin/blob/develop/composer.json#L21

This results in a lot of payment provider packages beeing installed by composer, when there are currently only two being implemented. I suggest to only require the providers that are implemented.

Here is a log from my composer install:

  - Installing omnipay/common (v2.3.4): Downloading (100%)
  - Installing omnipay/worldpay (v2.2.2): Downloading (100%)
  - Installing omnipay/targetpay (v2.2.1): Downloading (100%)
  - Installing omnipay/stripe (V2.4.7): Downloading (100%)
  - Installing omnipay/securepay (2.2.0): Downloading (100%)
  - Installing omnipay/sagepay (2.4.1): Downloading (100%)
  - Installing omnipay/pin (v2.2.2): Downloading (100%)
  - Installing omnipay/paypal (v2.6.4): Downloading (100%)
  - Installing omnipay/paymentexpress (v2.2.2): Downloading (100%)
  - Installing omnipay/payflow (v2.3.1): Downloading (100%)
  - Installing omnipay/payfast (v2.2): Downloading (100%)
  - Installing omnipay/netbanx (v2.2): Downloading (100%)
  - Installing omnipay/netaxept (v2.3.0): Downloading (100%)
  - Installing omnipay/multisafepay (v2.3.6): Downloading (100%)
  - Installing omnipay/mollie (v3.2.0): Downloading (100%)
  - Installing omnipay/migs (v2.2.2): Downloading (100%)
  - Installing omnipay/manual (v2.2.1): Downloading (100%)
  - Installing omnipay/gocardless (2.2.0): Downloading (100%)
  - Installing omnipay/firstdata (v2.4.0): Downloading (100%)
  - Installing omnipay/eway (v2.2.2): Downloading (100%)
  - Installing omnipay/dummy (v2.2.0): Downloading (100%)
  - Installing omnipay/coinbase (v2.0.4): Downloading (100%)
  - Installing omnipay/cardsave (2.1.2): Downloading (100%)
  - Installing omnipay/buckaroo (v2.2.0): Downloading (100%)
  - Installing omnipay/authorizenet (2.6.0): Downloading (100%)
  - Installing omnipay/2checkout (v2.1.1): Downloading (100%)
  - Installing league/omnipay (2.3.2)
tobias-kuendig commented 5 years ago

Good point. Let's fix this with the migration to Omnipay 3.0.