search

OFFLINE-GmbH / oc-responsive-images-plugin

Adds reponsive images capabilities to October CMS
MIT License
45 stars 26 forks source link

Refactored FocusPoint is bugged #113

Closed zbigniew-glazer closed 3 months ago

zbigniew-glazer commented 3 months ago

October CMS crashes with the following error when using this type of tag in my layout:

{variable type="section" label="Lista" tab="Pricelist"}{/variable} {repeater name="section" groups="themes/deo/meta/pricelist.yaml" tab="Price List" prompt="Add item"} {# parser fail if there is noting between open and close tag #} {/repeater}

Can't edit the page and getting this kind of error: "OFFLINE\ResponsiveImages\Classes\Focuspoint\FocuspointExtension::OFFLINE\ResponsiveImages\Classes\Focuspoint{closure}(): Argument #1 ($path) must be of type string, null given, called in /home/admin/domains/demo/public_html/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php on line 421" on line 21 of /home/admin/domains/demo/public_html/plugins/offline/responsiveimages/classes/focuspoint/FocuspointExtension.php

error I had to roll back to 2.6.3

tobias-kuendig commented 3 months ago

Thank you for the report! This is fixed in v2.7.3.

zbigniew-glazer commented 3 months ago

Wow. You are quick! Thanks