Support money_format function for windows platforms

OFFLINE-GmbH / oc-snipcartshop-plugin

Ecommerce solution for October CMS using snipcart.com as a backend

MIT License

11 stars 4 forks source link

Support money_format function for windows platforms #2

Closed mohammed-alsiddeeq closed 7 years ago

mohammed-alsiddeeq commented 7 years ago

money_format is not supported in windows platform as per the PHP website ( in the Note section) This is a work around to add some support.

tobias-kuendig commented 7 years ago

Thank you for bringing this to my attention. Your implementation looks pretty complex. Could you try to replace your helpers.php with this version and see if it works?

https://github.com/OFFLINE-GmbH/oc-snipcartshop-plugin/blob/2c7b6cd554a72f7082bcfadf387905a437258514/helpers.php

tobias-kuendig commented 7 years ago

Version 1.0.5 has been released with support for Windows platforms. Thanks for bringing the issue to our attention! :+1: