search

OFFLINE-GmbH / oc-snipcartshop-plugin

Ecommerce solution for October CMS using snipcart.com as a backend
MIT License
11 stars 4 forks source link

Product price should be plain text input not a repeater #3

Open mohammed-alsiddeeq opened 7 years ago

mohammed-alsiddeeq commented 7 years ago

Frankly i did not met any case where a Price should be entered for every currency individually. Is there a certain thing you are targeting with this implementation? I think Price fields in products should be text input not a repeater. And the currency should be set globally not per product. What i am suggesting is making the currencies configured by the store globally, the same as adding languages(already done), and the frontend currency picker just calculate and convert the relative currencies using a currency exchange api ( Yahoo for example, and can be configurable for adding other specific APIs). What do you think @tobias-kuendig or @abhi1693 ?

tobias-kuendig commented 7 years ago

To be honest, it was the simplest implementation at the time. I know it's not the best solution for this. I'll leave this issue open, I guess there's nothing against an automated calculation of the prices but I won't have time to implement it right now... maybe in the comming weeks. Our first goal with this plugin was to rebuild the Snipcart attributes in October and then add additional functionality like this later.