OFS / opae-sdk

Open Programmable Acceleration Engine
https://ofs.github.io
BSD 3-Clause "New" or "Revised" License
258 stars 82 forks source link

fix:set continuous mode bit for write hit/miss cases tests #3062

Closed anandaravuri closed 10 months ago

anandaravuri commented 10 months ago

CXL HE write hit/miss cases, sets continuous mode bit in rd_cfg instead of wr_cfg. set continuous mode bit write hit/miss case tests.

Forced stop control register ResetL bit is low causes timeout failures set ResetL too high for forced stop

tswhison commented 10 months ago

Could you provide some description in the commit message indicating why the change is required?

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 7227997314


Changes Missing Coverage Covered Lines Changed/Added Lines %
samples/cxl_host_exerciser/cxl_he_cache_cmd.h 0 5 0.0%
<!-- Total: 0 5 0.0% -->
Files with Coverage Reduction New Missed Lines %
samples/cxl_host_exerciser/cxl_he_cache_cmd.h 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 7227971434: -0.003%
Covered Lines: 15756
Relevant Lines: 23670

💛 - Coveralls
anandaravuri commented 10 months ago

Can add to the commit message as to why this needs to be done and why the change involving removing setting he_rwcfg.continuous_mode_enable?

Ananda: updated commit meassge with comments