OFS / opae-sdk

Open Programmable Acceleration Engine
https://ofs.github.io
BSD 3-Clause "New" or "Revised" License
251 stars 83 forks source link

Feature: add --force, --enable-sriov to opae.io #3079

Closed fpgamatt closed 8 months ago

fpgamatt commented 8 months ago

Add --force and --enable-sriov options to the subparser for opae.io init. The --force option enables controlling the force parameter to vfio_init() that was previously hard-coded to False.

The --enable-sriov option, when given, causes opae.io init to write 'Y' to /sys/module/vfio_pci/parameters/enable_sriov.

The default value for both options is False.

PR Title should start with one of the following tags: [Fix]/[Feature]/[Style]/[Update]

[Fix]- Bug Fix

[Feature]- for new feature

[Style]- Grammar or branding fix

[Update]-For an update to an existing feature

------------- Keep everything below this line -------------------------

Description

Describe the issue, update, change or fix and why

Collateral (docs, reports, design examples, case IDs):

Tests added:

Tests run:

pcolberg commented 8 months ago

The docs are still failing:

The conflict is caused by:
    The user requested sphinx==5.0.0
    …
    breathe 4.33.1 depends on Sphinx<5 and >=3.0
fpgamatt commented 8 months ago

Yea! All checks have passed. Now I need an approval.

fpgamatt commented 8 months ago

I only see the option to "Squash and merge" as enabled. Why can't I "Rebase and merge" because I was to keep the 3 commits separate.

pcolberg commented 8 months ago

@fpgamatt Rebase and merge should be enabled now.

fpgamatt commented 8 months ago

Thanks Peter! I see Rebase and merge.