OFS / opae-sdk

Open Programmable Acceleration Engine
https://ofs.github.io
BSD 3-Clause "New" or "Revised" License
251 stars 84 forks source link

fpgainfo: Remove the sdm hash and cancel keys from CMC fpgainfo security #3099

Closed anandaravuri closed 6 months ago

anandaravuri commented 6 months ago

The CMC platform does not support SDM PR and SR key hashes/cancel keys; therefore, remove them from the CMC board module Update the security key enumeration and read sysfs attribute logic into table format.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 7879099070

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/libboard/board_cmc/board_cmc.c 0 21 0.0%
<!-- Total: 0 21 0.0% -->
Files with Coverage Reduction New Missed Lines %
libraries/libboard/board_cmc/board_cmc.c 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 7846970785: 0.2%
Covered Lines: 15809
Relevant Lines: 24449

💛 - Coveralls
fpgamatt commented 6 months ago

Hi Ananda,

Please squash/fix the 5 commits such that there are only two commits as Peter requested.

The first commit removes the unsupported #defines and code using them.

The second commit should be turning the linear code into a table and a for loop.