OFS / opae-sdk

Open Programmable Acceleration Engine
https://ofs.github.io
BSD 3-Clause "New" or "Revised" License
251 stars 84 forks source link

mem_tg: fix support for more than 8 memory channels #3138

Closed pcolberg closed 2 weeks ago

pcolberg commented 1 month ago

The sizeof() operator returns the size of an object or type in bytes, not bits. Instead of calculating the number of bits using, e.g., CHAR_BIT * sizeof(), hard-code 64 since it is close to the declaration.

This is a prerequisite for HBM support with up to 32 channels.

Link: https://github.com/OFS/opae-sdk/issues/3137 Fixes: 7bf96dc98995 ("mem_tg test multichannel")

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10455767815

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
samples/mem_tg/tg_test.h 0 23 0.0%
<!-- Total: 0 23 0.0% -->
Files with Coverage Reduction New Missed Lines %
samples/mem_tg/tg_test.h 3 0.0%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 10306205386: 0.03%
Covered Lines: 15826
Relevant Lines: 24634

💛 - Coveralls