search

OGGM / oggm-edu

Educational material about glaciers, powered by OGGM and MyBinder
http://edu.oggm.org
BSD 3-Clause "New" or "Revised" License
22 stars 29 forks source link

Add name attribute to 'Glacier' and 'GlacierCollection' objects #187

Closed ehultee closed 1 year ago

ehultee commented 1 year ago

After last year's updates, the workflow to make an experiment (like the simple bed slope comparison that can be compared with goo) has changed.

Students modifying the new workflow noticed that it would be helpful to add a 'Name' attribute to Glacier and GlacierCollection objects. This would help with bookkeeping when there are several idealized glaciers that the students are supposed to compare with one another.

Holmgren825 commented 1 year ago

Hey Lizz! This sounds like a good addition. I can take a look at it. Spontaneously I'm thinking of adding it as an optional argument which by default assigns a random id to the glacier if no name is provided.

ehultee commented 1 year ago

Sounds great. Thank you Erik!

fmaussion commented 1 year ago

I've commented on the PR. I think it needs a bit more thinking as to what to do "per default", because the new default IDs will be quite unintuitive.