Additions to the where_are_the_flowlines notebook

OGGM / tutorials

Notebook tutorials for the Open Global Glacier Model (OGGM)

https://tutorials.oggm.org

BSD 3-Clause "New" or "Revised" License

18 stars 18 forks source link

Additions to the where_are_the_flowlines notebook #42

Closed anoukvlug closed 3 years ago

anoukvlug commented 3 years ago

This PR addresses issue #35 and adds to the where_are_the_flowlines notebook. It adds a part about the new flowline diagnostics.

I would be happy if someone would provide feedback :) (e.g. if it is clear/ if your missing something/ if it's to long)

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

fmaussion commented 3 years ago

I like it, thanks!! But I think you should use the opportunity to write text in notebook cells as well! (instead of using code comments only as you do right now)

anoukvlug commented 3 years ago

Thanks for the suggestion :) I will change that.

fmaussion commented 3 years ago

That's great thanks! I made some suggestions. In the process I realized one or two things that need attention in OGGM, let;s discuss tomorrow ;-)

fmaussion commented 3 years ago

Thanks @anoukvlug !