search

OGGM / tutorials

Notebook tutorials for the Open Global Glacier Model (OGGM)
https://tutorials.oggm.org
BSD 3-Clause "New" or "Revised" License
18 stars 18 forks source link

removed utils.mkdir with reset=True for most ipynb #48

Closed lilianschuster closed 2 years ago

lilianschuster commented 2 years ago

In the tutorials, the working_dir was often created via utils.mkdir(...., reset=True). When people use this on folders with other data, the content of the folder can get removed. To not bring people to the idea of using this, we use now on almost all tutorials the utils.gettempdir(..., reset=True) option. In some cases, utils.mkdir(...., reset=True) is still used, but then I added a warning in the code (as suggested by @fmaussion):

Beware! If you use reset=True in utils.mkdir, ALL DATA in this folder will be deleted! Use with caution!

Thanks to Kim Cholibois for reporting this issue!

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

fmaussion commented 2 years ago

:raised_hands: thanks!