search

OGGM / tutorials

Notebook tutorials for the Open Global Glacier Model (OGGM)
https://tutorials.oggm.org
BSD 3-Clause "New" or "Revised" License
18 stars 18 forks source link

cfl error in merging_glaciers notebook #60

Open pat-schmitt opened 2 years ago

pat-schmitt commented 2 years ago

On the website a cfl error occurs in the merging_glaciers notebook. But I could not reproduce the error locally, not sure how to proceed.

fmaussion commented 2 years ago

Can you try to set cfl_number to 0.01?

pat-schmitt commented 2 years ago

I also could not reproduce with cfl_number 0.01 locally. I also created an env with the same oggm version as is used on mybinder and was not able to reproduce the error. Maybe there is something going on in the docker image. I can try to run the notebook from the image to reproduce the error.

pat-schmitt commented 2 years ago

ah and before this I test also with python 3.10

fmaussion commented 2 years ago

You can also try to push cfl to 0.01 in a PR and trigger a build online, but the problem is that we won't know what the problem is.

Maybe something in the output changed again :cry:

cc @TimoRoth

pat-schmitt commented 2 years ago

ok python 3.10 was not the problem. What do you mean with pushing cfl to 0.01? I tested on my binder with cfl 0.01 and the tutorial still fails.

fmaussion commented 2 years ago

Ah ok ok - great thanks.

fmaussion commented 2 years ago

Another solution would be to simplify this example or remove it, but that's some work or a bit sad,