OGRECave / ogitor

Ogitor SceneBuilder, the WYSIWYG scene editing environment for OGRE
MIT License
95 stars 31 forks source link

image load correction and correction dump splatting with an unassigned texture #34

Closed mitra-projects closed 3 years ago

mitra-projects commented 3 years ago

two corrections;

  1. it was not possible load the png height files without adding specifiying the image format in the image::load function.
  2. splat return error when the texture selected was still not assigned to a layer (so program try to add a new layer). The normal map associated to the diffuse map selected was not ready, so the resource load return an exception. The original code assumes the normal map name is concatenated to the diffuse map name with a ";" as separator in the widget, so I changed using this logic
paroj commented 3 years ago

:+1: thanks. but please write your changes into the "subject line" of the commit next time, so the commit overview looks sane.

mitra-projects commented 3 years ago

thanks; I open a new pull request with two corrections, I put only comments in the single files commit.

Il 28.09.2020 01:33, Pavel Rojtberg ha scritto:

👍 thanks. but please write your changes into the "subject line" of the commit next time, so the commit overview looks sane.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OGRECave/ogitor/pull/34#issuecomment-699703067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREFPEGNRHLNW3C4JLG3K6LSH7DVFANCNFSM4R3ZLTGQ.

-- Questa e-mail è stata controllata per individuare virus con Avast antivirus. https://www.avast.com/antivirus