Closed mitra-projects closed 3 years ago
Understood, I deleted and forked it again
Il 05.10.2020 20:20, Pavel Rojtberg ha scritto:
at some point you should rebase your fork on current master as the PRs are getting increasingly harder to review. (you could also delete your fork and fork again)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OGRECave/ogitor/pull/37#issuecomment-703804646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREFPEGX5MI6GK2VYX4VQ33SJIE7HANCNFSM4SE3AHXQ.
-- Questa e-mail è stata controllata per individuare virus con Avast antivirus. https://www.avast.com/antivirus
Just added anohter pull request; I setup the inputscale property from a constant to a GUi parameter; I noticed also that numeric parameters like skirt size when changed rewriting directly the number (not using the up\down arrow) created a crash, this seems due to the calling of system message after the change which created some crash inside qt routines; I disabled the warning message for inputscale and skirt size.
Il 05.10.2020 20:20, Pavel Rojtberg ha scritto:
at some point you should rebase your fork on current master as the PRs are getting increasingly harder to review. (you could also delete your fork and fork again)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OGRECave/ogitor/pull/37#issuecomment-703804646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREFPEGX5MI6GK2VYX4VQ33SJIE7HANCNFSM4SE3AHXQ.
-- Questa e-mail è stata controllata per individuare virus con Avast antivirus. https://www.avast.com/antivirus
Just created a new pull request; I changed the inputscale parameter from int to real
Il 05.10.2020 20:20, Pavel Rojtberg ha scritto:
at some point you should rebase your fork on current master as the PRs are getting increasingly harder to review. (you could also delete your fork and fork again)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OGRECave/ogitor/pull/37#issuecomment-703804646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREFPEGX5MI6GK2VYX4VQ33SJIE7HANCNFSM4SE3AHXQ.
-- Questa e-mail è stata controllata per individuare virus con Avast antivirus. https://www.avast.com/antivirus
at some point you should rebase your fork on current master as the PRs are getting increasingly harder to review. (you could also delete your fork and fork again)