search

OGRECave / ogre-audiovideo

plugins for theora video playback and openAL audio
https://ogrecave.github.io/ogre-audiovideo/
BSD 3-Clause "New" or "Revised" License
14 stars 11 forks source link

API correction regarding EFX Effect Slots #28

Closed sercero closed 3 years ago

sercero commented 3 years ago

@paroj, I wonder what do you think of this. The function getNumberOfSupportedEffectSlots() has a confusing name and description. It says EffectSlots but returns the Auxiliary Sends (not the same thing), the description is also mixing the two concepts.

So I created getMaxAuxiliaryEffectSlots() and getMaxAuxiliaryEffectSends() which are consistent in naming and description.

What do you think should be done with getNumberOfSupportedEffectSlots()? I thought of replicating the OGRE_DEPRECATED macro, but I don't understand where that macro is defined.

Found another bug when releasing the OpenAL effects and filters.

paroj commented 3 years ago

I thought of replicating the OGRE_DEPRECATED macro, but I don't understand where that macro is defined.

you could just use the ogre definition. It is in the CMake generated OgreExports.h. However..

What do you think should be done with getNumberOfSupportedEffectSlots()?

..you can just delete it. I doubt anyone is currently using it as you only implemented OpenAL Soft support for that just now.