Improve log messaging consistency and use logError where appropiate

OGRECave / ogre-audiovideo

plugins for theora video playback and openAL audio

https://ogrecave.github.io/ogre-audiovideo/

BSD 3-Clause "New" or "Revised" License

14 stars 11 forks source link

Improve log messaging consistency and use logError where appropiate #31

Closed sercero closed 3 years ago

sercero commented 3 years ago

Also:

Removed instances of using namespace Ogre, using namespace OgreOggSound and using namespace std
Replaced std::string with Ogre::String (for consistency, some places used it and others didn't)

paroj commented 3 years ago

Removed instances of using namespace Ogre, using namespace OgreOggSound and using namespace std

but, why?

sercero commented 3 years ago

Hello @paroj, I understand that it might be a bit heavy handed but what I don't like is inconsistency.

The were classes where it was using namespace Ogre and others not, even in the same class sometimes there was a using namespace Ogre and then something with Ogre::

I think in general it is best to be explicit to avoid errors (that is why, for example, I'm not a fan of auto although I recognise its usefullness sometimes).