OGRECave / ogre-audiovideo

plugins for theora video playback and openAL audio
https://ogrecave.github.io/ogre-audiovideo/
BSD 3-Clause "New" or "Revised" License
14 stars 11 forks source link

Add support for some OpenAL Soft extentions #34

Closed sercero closed 3 years ago

sercero commented 3 years ago

@paroj let me know if you want to take a look at the code or I'll just merge it.

Another thing: I need your help in doing a release before doing some changes to the API.

There are some problems with the current design and I was planning to make some changes to the API.

So I want to make a release before that.

Oh, another thing: image If I were to merge the pull request, which option should I choose?

Thanks!

paroj commented 3 years ago

If I were to merge the pull request, which option should I choose?

I prefer using rebase merge as this results in a cleaner history. Squash does the same, but combines all commits into one. This is useful to get rid of superficial "fixup" commits.

paroj commented 3 years ago

Another thing: I need your help in doing a release before doing some changes to the API.

releases are easy: