search

OGRECave / ogre-next

aka ogre v2 - scene-oriented, flexible 3D C++ engine
https://ogrecave.github.io/ogre-next/api/latest
Other
1.08k stars 233 forks source link

bugfix: memory leak due to undeleted stereo driver bridge #383

Closed Th3V1kt0r closed 1 year ago

Th3V1kt0r commented 1 year ago

Stereo driver must be freed after device is created.

This bug is probably also included in Ogre1.

paroj commented 1 year ago

out of interest: are you actually using QUAD_BUFFER_STEREO or just cleaning-up code?

darksylinc commented 1 year ago

out of interest: are you actually using QUAD_BUFFER_STEREO or just cleaning-up code?

He answered that question here https://github.com/OGRECave/ogre-next/pull/382#issuecomment-1534150098 as I had the same question

Th3V1kt0r commented 1 year ago

When we get our product working under Ogre2, then we will look at OpenVr. At the moment I can't say if we will use QBS in the future. I uploaded it so that when we update to higher version we don't have to keep updating our bug fixes.But I promise not to upload QBS bugs.I still have a few bugfixes. But I can't see directly if they are universal or specific for us.Can I send it to you and you decide?--Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 05.05.23, 15:37 schrieb "Matias N. Goldberg" @.***>:

out of interest: are you actually using QUAD_BUFFER_STEREO or just cleaning-up code?

He answered that question here #382 (comment) as I had the same question —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

darksylinc commented 1 year ago

I merged it manually to fix the clang format check fail.

Thanks for the PR!