search

OGRECave / ogre

scene-oriented, flexible 3D engine (C++, Python, C#, Java)
https://ogrecave.github.io/ogre/
MIT License
3.91k stars 963 forks source link

[BUG Report] Is SAFE_DELETE modified erroneously? #3048

Closed walker-WSH closed 6 months ago

walker-WSH commented 6 months ago

Hi, I find SAFE_DELETE is changed in this commit https://github.com/OGRECave/ogre/commit/ee5fd3b21f93101c5d5fe6bf0fa837ad70131c0a 1709178080

Should "delete p" be removed ?
This causes below variables can't be destroied normally since they are not managed by smart pointer ~

1709177916

By the way, this commit has been included in 14.2 while not in 14.1.2

paroj commented 6 months ago

yes, this was an overlook when merging. Thanks for reporting! Reverting..