search

OGRECave / ogre

scene-oriented, flexible 3D engine (C++, Python, C#, Java)
https://ogrecave.github.io/ogre/
MIT License
3.91k stars 963 forks source link

Changes in CMake files to avoid downloading bullet when it is not needed #3051

Closed Bimbloc closed 6 months ago

Bimbloc commented 6 months ago

Just a check before downloading bullet making sure the user is interested in building the ogre bullet module since otherwise bullet would not really be considered strictly necessary unlike sdl for example.

paroj commented 6 months ago

:+1: thanks!

paroj commented 6 months ago

had to revert this again after taking a closer look. The issue is that Dependencies are handled before the options, as options depend on the dependencies having been built: https://github.com/OGRECave/ogre/blob/254936ebf20ba9f80386a620803b09734bac44c4/CMakeLists.txt#L324

this leaves OGRE_BUILD_DEPENDENCIES an all or nothing setting for now

Bimbloc commented 6 months ago

Didn´t realize that :/. Hope it wasn't to much trouble!

El dom, 3 mar 2024 a las 22:32, Pavel Rojtberg @.***>) escribió:

had to revert this again after taking a closer look. The issue is that Dependencies are handled before the options, as options depend on the dependencies having been built:

https://github.com/OGRECave/ogre/blob/254936ebf20ba9f80386a620803b09734bac44c4/CMakeLists.txt#L324

this leaves OGRE_BUILD_DEPENDENCIES an all or nothing setting for now

— Reply to this email directly, view it on GitHub https://github.com/OGRECave/ogre/pull/3051#issuecomment-1975334137, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATUO5J4K3JYELRY54FMBS33YWOJHTAVCNFSM6AAAAABECKAFCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGMZTIMJTG4 . You are receiving this because you authored the thread.Message ID: @.***>